Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strict build of docs #971

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

strict build of docs #971

wants to merge 7 commits into from

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Aug 30, 2022

No description provided.

baronfel
baronfel reviewed Aug 30, 2022
View reviewed changes
.github/workflows/docs.yml Outdated
@@ -18,7 +18,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v1
with:
dotnet-version: 5.0.400
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of having to keep these versions up to date, if you have a global.json file in this repo you can update these actions to be:

- name: Setup .NET Core
  uses: action/setup-dotnet@v2

and the action will use the version constraints from the global.json, keeping them in sync from that point onward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need two sdks unfortunately, but it's all a bit messy. FsDocs likes to run with .NET 6 and we're currently building docs from "main" of dotnet/fsahrp, which likes whatever .NET 7 preview it's on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not even totally sure this separate docs build is worth it tbh, but if we want generated docs the only other solution would be to generate within dotnet/fsharp itself. But that would probably lead to integrating all of FSharp.Formatting into dotnet/fsharp, which is a big hit, leading to more and more monorepo. Perhaps it's what we should do.

@dsyme dsyme changed the title update to latest FSharp.Formatting strict build of docs Aug 30, 2022
@dsyme
Copy link
Contributor Author

dsyme commented Aug 30, 2022 •
edited
Loading

Strict doc build is failing, because

  1. Project cracking needs needs updating to .NET 7
  2. fsdocs needs needs updating to .NET 7
cracking projects...
  skipping project 'FSharp.Compiler.Service.fsproj' because an error occurred while cracking it: System.Exception: error - SDK Resolver Failure: "The SDK resolver "Microsoft.DotNet.MSBuildWorkloadSdkResolver" failed while attempting to resolve the SDK "Microsoft.NET.Sdk". Exception: "System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
File name: 'System.Runtime, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
   at Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver.WorkloadSdkResolver.Resolve(SdkReference sdkReference, SdkResolverContext resolverContext, SdkResultFactory factory)
   at Microsoft.Build.BackEnd.SdkResolution.SdkResolverService.ResolveSdk(Int32 submissionId, SdkReference sdk, LoggingContext loggingContext, ElementLocation sdkReferenceLocation, String solutionPath, String projectPath, Boolean interactive, Boolean isRunningInVisualStudio)""  D:\a\fsharp-compiler-docs\fsharp-compiler-docs\FSharp.Compiler.Service\FSharp.Compiler.Service.fsproj
log - 
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@143[9](https://github.com/fsharp/fsharp-compiler-docs/runs/8093770493?check_suite_focus=true#step:9:10).Invoke(String message)
   at [email protected](String p) in /home/runner/work/FSharp.Formatting/FSharp.Formatting/src/fsdocs-tool/ProjectCracker.fs:line 454
Project cracking failed and --strict is on, exiting

@baronfel
Copy link
Collaborator

There's a new version of proj-info with some fixes for 6.0.400 and onwards cracking that you'll probably need to take to unblock this, then.

@dsyme
Copy link
Contributor Author

dsyme commented Aug 30, 2022 •
edited
Loading

@baronfel Updated some packages here fsprojects/FSharp.Formatting#768

@dsyme dsyme closed this Nov 18, 2022
@dsyme dsyme reopened this Nov 18, 2022
@dsyme dsyme closed this Nov 28, 2022
@dsyme dsyme reopened this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsyme @baronfel